linux-kernel - Re: [PATCH 09/48] perf tools: Make copyfile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180918205450.GA311@kernel.org>
Date:   Tue, 18 Sep 2018 17:54:50 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Andi Kleen <andi@...stfloor.org>,
        Alexey Budankov <alexey.budankov@...ux.intel.com>
Subject: Re: [PATCH 09/48] perf tools: Make copyfile_offset global

Em Thu, Sep 13, 2018 at 02:54:11PM +0200, Jiri Olsa escreveu:
> It will be used outside of util object in following patches.

Had to add fcntl.h to have loff_t to fix the build in some systems,
moved the prototype closer to the other copyfile_ prefixed functions in
util.h.

- Arnaldo
 
> Link: http://lkml.kernel.org/n/tip-xgiypvcrmc12u7czcrc27en2@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> ---
>  tools/perf/util/util.c | 2 +-
>  tools/perf/util/util.h | 2 ++
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c
> index eac5b858a371..093352e93d50 100644
> --- a/tools/perf/util/util.c
> +++ b/tools/perf/util/util.c
> @@ -221,7 +221,7 @@ static int slow_copyfile(const char *from, const char *to, struct nsinfo *nsi)
>  	return err;
>  }
>  
> -static int copyfile_offset(int ifd, loff_t off_in, int ofd, loff_t off_out, u64 size)
> +int copyfile_offset(int ifd, loff_t off_in, int ofd, loff_t off_out, u64 size)
>  {
>  	void *ptr;
>  	loff_t pgoff;
> diff --git a/tools/perf/util/util.h b/tools/perf/util/util.h
> index dc58254a2b69..7fc171b20671 100644
> --- a/tools/perf/util/util.h
> +++ b/tools/perf/util/util.h
> @@ -80,4 +80,6 @@ void perf_set_multithreaded(void);
>  #endif
>  #endif
>  
> +int copyfile_offset(int ifd, loff_t off_in, int ofd, loff_t off_out, u64 size);
> +
>  #endif /* GIT_COMPAT_UTIL_H */
> -- 
> 2.17.1