linux-kernel - Re: [PATCH] net: apm: xgene: force XGene enet driver to re-balance IRQ usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29258606-8255-847c-b22f-8793999ce6fe@gmail.com>
Date:   Tue, 18 Sep 2018 16:56:13 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>, ahs3@...hat.com,
        "Lendacky, Thomas" <Thomas.Lendacky@....com>,
        David Miller <davem@...emloft.net>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "isubramanian@....com" <isubramanian@....com>,
        "kchudgar@....com" <kchudgar@....com>,
        "qnguyen@....com" <qnguyen@....com>
Subject: Re: [PATCH] net: apm: xgene: force XGene enet driver to re-balance
 IRQ usage



On 09/18/2018 04:27 PM, Eric Dumazet wrote:
> 

> I remember one of the napi_complete_done() change had to be reverted,
> for some obscure reason.



That was not exactly a revert,  :

commit 129c6cda2de2a8ac44fab096152469999b727faf
Author: Eric Dumazet <edumazet@...gle.com>
Date:   Mon Sep 18 13:03:43 2017 -0700

    8139too: revisit napi_complete_done() usage
    
    It seems we have to be more careful in napi_complete_done()
    use. This patch is not a revert, as it seems we can
    avoid bug that Ville reported by moving the napi_complete_done()
    test in the spinlock section.
    
    Many thanks to Ville for detective work and all tests.
    
    Fixes: 617f01211baf ("8139too: use napi_complete_done()")
    Reported-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>
    Tested-by: Ville Syrjälä <ville.syrjala@...ux.intel.com>
    
    Signed-off-by: David S. Miller <davem@...emloft.net>