linux-kernel - Re: linux-next: build failure after merge of the tty tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Ve8ecT4ziJrV9Edq6u0+jg-eQ1Z9wpXn4dvxTqFDHRFrA@mail.gmail.com>
Date:   Tue, 18 Sep 2018 07:54:09 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Greg KH <greg@...ah.com>,
        linux-next <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Radu Pirea <radu.pirea@...rochip.com>,
        Rob Herring <robh@...nel.org>
Subject: Re: linux-next: build failure after merge of the tty tree

On Tue, Sep 11, 2018 at 11:43 AM Lee Jones <lee.jones@...aro.org> wrote:
> On Tue, 11 Sep 2018, Nicolas Ferre wrote:

> > Actually it is due to the missing of  <linux/mod_devicetable.h> as Stephen
> > suggested. It is due to the patch ac3167257b9f ("headers: separate
> > linux/mod_devicetable.h from linux/platform_device.h") merged in v4.19-rc1.
>
> Since this set uses Device Tree, it really should include the of.h.

I didn't remember the contents of the driver, but I would disagree on
a statement that
*using* of_device_id table implies necessity of linux/of.h inclusion.

>
> This solves the issue reported above.
>
> I will fix-up and re-send the pull-request.


-- 
With Best Regards,
Andy Shevchenko