linux-kernel - Re: [PATCH 3/3] microblaze: uapi header and system call table file generation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Sep 2018 12:42:39 +0530
From:   Firoz Khan <firoz.khan@...aro.org>
To:     Michal Simek <michal.simek@...inx.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        y2038@...ts.linaro.org, linux-kernel@...r.kernel.org,
        linux-arch@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Marcin Juszkiewicz <marcin.juszkiewicz@...aro.org>
Subject: Re: [PATCH 3/3] microblaze: uapi header and system call table file generation

On 9 August 2018 at 12:42, Michal Simek <michal.simek@...inx.com> wrote:
> On 9.8.2018 07:27, Firoz Khan wrote:
>> System call table generation script must be run to generate
>> unistd_32.h and syscall_table.h files. This patch will have
>> changes which will invokes the script.
>>
>> This patch will generate unistd_32.h and syscall_table.h
>> files by the syscall table generation script invoked by
>> arch/microblaze/Makefile and the generated files against the
>> removed files will be identical.
>>
>> The generated uapi header file will be included in
>> uapi/asm/unistd.h and generated system call table support
>> file will be included by microblaze/kernel/syscall.S file.
>>
>> Signed-off-by: Firoz Khan <firoz.khan@...aro.org>
>> ---
>>  arch/microblaze/Makefile                  |   3 +
>>  arch/microblaze/include/asm/Kbuild        |   2 +
>>  arch/microblaze/include/uapi/asm/Kbuild   |   2 +
>>  arch/microblaze/include/uapi/asm/unistd.h | 409 +-----------------------------
>>  arch/microblaze/kernel/syscall_table.S    | 406 +----------------------------
>>  5 files changed, 12 insertions(+), 810 deletions(-)
>>
>> diff --git a/arch/microblaze/Makefile b/arch/microblaze/Makefile
>> index d269dd4b..6121a2b 100644
>> --- a/arch/microblaze/Makefile
>> +++ b/arch/microblaze/Makefile
>> @@ -81,6 +81,9 @@ all: linux.bin
>>  archclean:
>>       $(Q)$(MAKE) $(clean)=$(boot)
>>
>> +archheaders:
>> +     $(Q)$(MAKE) $(build)=arch/microblaze/kernel/syscalls all
>> +
>>  linux.bin linux.bin.gz linux.bin.ub: vmlinux
>>       $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
>>
>> diff --git a/arch/microblaze/include/asm/Kbuild b/arch/microblaze/include/asm/Kbuild
>> index fe6a6c6..99225ab 100644
>> --- a/arch/microblaze/include/asm/Kbuild
>> +++ b/arch/microblaze/include/asm/Kbuild
>> @@ -30,3 +30,5 @@ generic-y += trace_clock.h
>>  generic-y += vga.h
>>  generic-y += word-at-a-time.h
>>  generic-y += xor.h
>> +
>> +generated-y += syscall_table.h
>> \ No newline at end of file
>
> This doesn't look right.

You mean I have to keep something like this?
 generic-y += xor.h
-
-generated-y += syscall_table.h
\ No newline at end of file
+generic-y += syscall_table.h
\ No newline at end of file

>
>
>> diff --git a/arch/microblaze/include/uapi/asm/Kbuild b/arch/microblaze/include/uapi/asm/Kbuild
>> index 2c6a6bf..8fe26a3 100644
>> --- a/arch/microblaze/include/uapi/asm/Kbuild
>> +++ b/arch/microblaze/include/uapi/asm/Kbuild
>> @@ -28,3 +28,5 @@ generic-y += termbits.h
>>  generic-y += termios.h
>>  generic-y += types.h
>>  generic-y += ucontext.h
>> +
>> +generated-y += unistd_32.h
>> \ No newline at end of file
>
> ditto.

and like this?

 generic-y += ucontext.h
-
-generated-y += unistd_32.h
\ No newline at end of file
+generic-y += unistd_32.h
\ No newline at end of file

- Firoz