linux-kernel - RE: [PATCH] misc: remove redundant include moduleparam.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Sep 2018 08:49:32 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     zhong jiang <zhongjiang@...wei.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "arnd@...db.de" <arnd@...db.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] misc: remove redundant include moduleparam.h

> module.h already contains moduleparam.h,  so it is safe to remove the
> redundant include.
> 
> The issue is detected with the help of Coccinelle.
> 
> eePlease enter the commit message for your changes. Lines starting
> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  drivers/misc/mei/bus-fixup.c      | 1 -
>  drivers/misc/vmw_vmci/vmci_host.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c index
> a6f41f9..80215c3 100644
> --- a/drivers/misc/mei/bus-fixup.c
> +++ b/drivers/misc/mei/bus-fixup.c

Ack.
Tomas

> @@ -17,7 +17,6 @@
>  #include <linux/kernel.h>
>  #include <linux/sched.h>
>  #include <linux/module.h>
> -#include <linux/moduleparam.h>
>  #include <linux/device.h>
>  #include <linux/slab.h>
>  #include <linux/uuid.h>
> diff --git a/drivers/misc/vmw_vmci/vmci_host.c
> b/drivers/misc/vmw_vmci/vmci_host.c
> index 83e0c95..be732e5 100644
> --- a/drivers/misc/vmw_vmci/vmci_host.c
> +++ b/drivers/misc/vmw_vmci/vmci_host.c
> @@ -15,7 +15,6 @@
> 
>  #include <linux/vmw_vmci_defs.h>
>  #include <linux/vmw_vmci_api.h>
> -#include <linux/moduleparam.h>
>  #include <linux/miscdevice.h>
>  #include <linux/interrupt.h>
>  #include <linux/highmem.h>
> --
> 1.7.12.4