linux-kernel - Re: [PATCH] x86/speculation: Use AMD specific retpoline for inline asm on AMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <caeb3213f13e57191e362ca04f2892cfa2ccda65.camel@infradead.org>
Date:   Tue, 18 Sep 2018 14:32:52 +0100
From:   David Woodhouse <dwmw2@...radead.org>
To:     Peter Zijlstra <peterz@...radead.org>,
        Zhenzhong Duan <zhenzhong.duan@...cle.com>
Cc:     linux-kernel@...r.kernel.org, mingo@...hat.com,
        konrad.wilk@...cle.com, x86@...nel.org, tglx@...utronix.de,
        Srinivas REDDY Eeda <srinivas.eeda@...cle.com>, bp@...e.de,
        hpa@...or.com, dhaval.giani@...cle.com
Subject: Re: [PATCH] x86/speculation: Use AMD specific retpoline for inline
 asm on AMD

On Tue, 2018-09-18 at 15:03 +0200, Peter Zijlstra wrote:
> > > In original code, it will go to "call *%[thunk_target]\n" while
> > > we have set SPECTRE_V2_RETPOLINE_MINIMAL or
> > > SPECTRE_V2_RETPOLINE_MINIMAL_AMD. Is this expected?
> > 
> > Yes, that is exactly right -- it does that with or without your change
> > though.
> 
> Soryr, I wrote that before I noticed the CONFIG_RETPOLINE vs RETPOLINE
> thing.
> 
> In any case, since retpoline capable compilers are widely available, I'm
> all for making CONFIG_RETPOLINE hard depend on it. That minimal stuff
> really is quite silly.

Yep, now the the compiler support is widespread that makes a lot of
sense.

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5213 bytes)