linux-kernel - Re: [PATCH 2/3] tty_port: Fix function name and brief desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180918133715.GB23431@kroah.com>
Date:   Tue, 18 Sep 2018 15:37:15 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Tobin C. Harding" <me@...in.cc>
Cc:     Jiri Slaby <jslaby@...e.com>, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH 2/3] tty_port: Fix function name and brief desc

On Wed, Sep 12, 2018 at 05:50:43PM +1000, Tobin C. Harding wrote:
> @@ -235,7 +235,7 @@ void tty_port_free_xmit_buf(struct tty_port *port)
>  EXPORT_SYMBOL(tty_port_free_xmit_buf);
>  
>  /**
> - * tty_port_destroy -- destroy inited port
> + * tty_port_destroy() - Destroy inited port.

Ok, using () for a function name, that's fine, but then you do:

>  /**
> - *	tty_port_tty_set	-	set the tty of a port
> - *	@port: tty port
> - *	@tty: the tty
> + * tty_port_tty_set - Set the tty of a port.

Oops, not here.  Consistency is the key.

thanks,

greg k-h