linux-kernel - Re: [PATCH v2] tty: rocket: Fix possible buffer overwrite on register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180918133759.GA20312@kroah.com>
Date:   Tue, 18 Sep 2018 15:37:59 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Anton Vasilyev <vasilyev@...ras.ru>
Cc:     Alan Cox <gnomes@...rguk.ukuu.org.uk>,
        Jiri Slaby <jslaby@...e.com>, linux-kernel@...r.kernel.org,
        ldv-project@...uxtesting.org
Subject: Re: [PATCH v2] tty: rocket: Fix possible buffer overwrite on
 register_PCI

On Mon, Aug 06, 2018 at 05:10:57PM +0300, Anton Vasilyev wrote:
> If number of isa and pci boards exceed NUM_BOARDS on the path
> rp_init()->init_PCI()->register_PCI() then buffer overwrite occurs
> in register_PCI() on assign rcktpt_io_addr[i].
> 
> The patch adds check on upper bound for index of registered
> board in register_PCI.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Anton Vasilyev <vasilyev@...ras.ru>
> ---
> v2: do not enable device which will not be managed by driver.
> Based on Alan's comment.

This patch doesn't apply to my tree at all :(

Can you rebase and resend?

thanks,

greg k-h