linux-kernel - Re: [PATCH] staging: erofs: initialize `pblk' with 0 first in `z_erofs_map_blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Sep 2018 22:06:09 +0800
From:   Gao Xiang <gaoxiang25@...wei.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     <devel@...verdev.osuosl.org>, <linux-erofs@...ts.ozlabs.org>,
        Chao Yu <yuchao0@...wei.com>,
        LKML <linux-kernel@...r.kernel.org>, <weidu.du@...wei.com>,
        Miao Xie <miaoxie@...wei.com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH] staging: erofs: initialize `pblk' with 0 first in
 `z_erofs_map_blocks_iter'

Hi Greg,

On 2018/9/18 21:57, Greg Kroah-Hartman wrote:
> On Tue, Sep 18, 2018 at 09:44:36PM +0800, Gao Xiang wrote:
>> This commit message helps to understand why `pblk' is assigned with 0 here.
>>
>> [ Greg reported a warning raised by gcc. ]
>> In file included from drivers/staging/erofs/unzip_vle.h:16:0,
>>                  from drivers/staging/erofs/unzip_vle.c:13:
>> drivers/staging/erofs/unzip_vle.c: In function ‘z_erofs_map_blocks_iter’:
>> drivers/staging/erofs/internal.h:303:34: warning: ‘pblk’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>>  #define blknr_to_addr(nr)       ((erofs_off_t)(nr) * EROFS_BLKSIZ)
>>                                   ^
>> drivers/staging/erofs/unzip_vle.c:1574:20: note: ‘pblk’ was declared here
>>   erofs_blk_t mblk, pblk;
>>                     ^~~~
>>
>> Actually, it is a false-positive warning when looking into that. [1]
>> Just initialize the variable to keep gcc from printing foolish warnings.
>>
>> [1] https://lists.ozlabs.org/pipermail/linux-erofs/2018-September/000637.html
>>
>> Reported-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Thanks-to: Dan Carpenter <dan.carpenter@...cle.com>
>> Signed-off-by: Gao Xiang <gaoxiang25@...wei.com>
>> ---
>>  drivers/staging/erofs/unzip_vle.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Please roll this into the original patch.  I have dropped that whole
> series from my tree, it is no longer present and needs to be resent in
> order for me to be able to accept any of these.

OK, will send. it's my honor.

Thanks,
Gao Xiang

> 
> thanks,
> 
> greg k-h
>