linux-kernel - Re: [PATCH] PCI: meson: fix ptr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180918143554.GC32243@e107981-ln.cambridge.arm.com>
Date:   Tue, 18 Sep 2018 15:35:54 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     kbuild test robot <fengguang.wu@...el.com>
Cc:     Hanjie Lin <hanjie.lin@...ogic.com>, kbuild-all@...org,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Yue Wang <yue.wang@...ogic.com>,
        Kevin Hilman <khilman@...libre.com>,
        Rob Herring <robh@...nel.org>, linux-kernel@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org
Subject: Re: [PATCH] PCI: meson: fix ptr_ret.cocci warnings

On Tue, Aug 14, 2018 at 07:45:18PM +0800, kbuild test robot wrote:
> From: kbuild test robot <fengguang.wu@...el.com>
> 
> drivers/pci/controller/dwc/pci-meson.c:121:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> 
>  Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> Fixes: b43bb00f7533 ("PCI: meson: add the Amlogic Meson PCIe controller driver")
> CC: Yue Wang <yue.wang@...ogic.com>
> Signed-off-by: kbuild test robot <fengguang.wu@...el.com>
> ---
> 
>  pci-meson.c |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

I have dropped this patch from the PCI patch queue since it was
taken into account in updated patches versions, thanks for sending
it.

Thanks,
Lorenzo

> --- a/drivers/pci/controller/dwc/pci-meson.c
> +++ b/drivers/pci/controller/dwc/pci-meson.c
> @@ -118,10 +118,7 @@ static int meson_pcie_get_mem(struct pla
>  		return -ENODEV;
>  
>  	mp->mem_res.cfg_base = devm_ioremap_resource(dev, res);
> -	if (IS_ERR(mp->mem_res.cfg_base))
> -		return PTR_ERR(mp->mem_res.cfg_base);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(mp->mem_res.cfg_base);
>  }
>  
>  static int meson_pcie_init_clk(struct meson_pcie *mp)