linux-kernel - Re: [PATCH net-next] net: fix return type of ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Sep 2018 09:30:56 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <dev@...nvswitch.org>
Subject: Re: [PATCH net-next] net: fix return type of ndo_start_xmit function



On 2018/9/17 23:09, David Miller wrote:
> 
> Please don't do this.
> 
> The hard part of fixing this is not what you are doing, changing the
> return type.
> 
> The hard part is fixing each and every function to actually return
> values which are members of the netdev_tx_t enumeration.
> 
> Please fix each and every function properly.

Ok, I will do it, thank you for review.

> 
> Thank you.
> 
> .
>