linux-kernel - Re: [PATCH] perf tools: Initialize perf_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Sep 2018 15:59:44 -0300
From:   Arnaldo Carvalho de Melo <acme@...hat.com>
To:     Jérémie Galarneau 
        <jeremie.galarneau@...icios.com>
Cc:     Jiri Olsa <jolsa@...hat.com>, lkml <linux-kernel@...r.kernel.org>,
        Jiri Olsa <jolsa@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Subject: Re: [PATCH] perf tools: Initialize perf_data_file fd field

Em Tue, Sep 18, 2018 at 02:07:41PM -0400, Jérémie Galarneau escreveu:
> Hi Arnaldo,
> 
> Anything I can do to help you with this patch?

Thanks for the reminder, will apply.

- Arnaldo
 
> Thanks,
> Jérémie
> 
> On 5 September 2018 at 12:09, Jiri Olsa <jolsa@...hat.com> wrote:
> > On Wed, Aug 29, 2018 at 04:16:48PM -0400, Jérémie Galarneau wrote:
> >> Building the perf CTF converter fails with gcc 4.8.4
> >> on Ubuntu 14.04 with the following error:
> >>
> >> error: missing initializer for field ‘fd’ of ‘struct perf_data_file’
> >> [-Werror=missing-field-initializers]
> >>
> >> Per 4b838b0d and the ensuing discussion on the mailing
> >> list, it appears that this affects other distributions
> >> and gcc versions.
> >>
> >> Signed-off-by: Jérémie Galarneau <jeremie.galarneau@...icios.com>
> >
> > Acked-by: Jiri Olsa <jolsa@...nel.org>
> >
> > thanks,
> > jirka
> >
> >> Cc: Jiri Olsa <jolsa@...nel.org>
> >> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> >> Cc: Peter Zijlstra <peterz@...radead.org>
> >> Cc: Ingo Molnar <mingo@...hat.com>
> >> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
> >> ---
> >>  tools/perf/util/data-convert-bt.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
> >> index abd38abf1d91..f75d4aa612c5 100644
> >> --- a/tools/perf/util/data-convert-bt.c
> >> +++ b/tools/perf/util/data-convert-bt.c
> >> @@ -1578,7 +1578,7 @@ int bt_convert__perf2ctf(const char *input, const char *path,
> >>  {
> >>       struct perf_session *session;
> >>       struct perf_data data = {
> >> -             .file.path = input,
> >> +             .file      = { .path = input, .fd = -1 },
> >>               .mode      = PERF_DATA_MODE_READ,
> >>               .force     = opts->force,
> >>       };
> >> --
> >> 2.18.0
> >>
> 
> 
> 
> -- 
> Jérémie Galarneau
> EfficiOS Inc.
> http://www.efficios.com