linux-kernel - Re: [PATCH v2 03/22] pinctrl: mediatek: extend struct mtk_pin_field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdabZop+9L5Hq9pCrYmHXug_qpm6QZV99HdnBh_ecXLnVw@mail.gmail.com>
Date:   Tue, 18 Sep 2018 12:43:17 -0700
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Sean Wang <sean.wang@...iatek.com>
Cc:     "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Ryder Lee <ryder.lee@...iatek.com>
Subject: Re: [PATCH v2 03/22] pinctrl: mediatek: extend struct
 mtk_pin_field_calc to pinctrl-mtk-common-v2.c

On Sat, Sep 8, 2018 at 4:08 AM <sean.wang@...iatek.com> wrote:

> From: Sean Wang <sean.wang@...iatek.com>
>
> This patch adds members sz_reg fixed in struct mtk_pin_field_calc
>
> - The 'fixed' is used to represent the consecutive pins share the same
> bits within the same register with the 1st pin so that it can largely
> reduce the entry size a bit.
>
> - The 'sz_reg' is used to indicate the range of bits we use in a register
>   that may vary by SoC
>
> The above changes make the code more generic and this is useful as there
> might be other existing or future chips all use the same logic to access
> their register set and then being a little more abstract could help in the
> long run.
>
> Signed-off-by: Ryder Lee <ryder.lee@...iatek.com>
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>

Patch applied.

Yours,
Linus Walleij