linux-kernel - Re: [PATCH] net: apm: xgene: force XGene enet driver to re-balance IRQ usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180917.193531.1424852853827678152.davem@davemloft.net>
Date:   Mon, 17 Sep 2018 19:35:31 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ahs3@...hat.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        isubramanian@....com, kchudgar@....com, qnguyen@....com
Subject: Re: [PATCH] net: apm: xgene: force XGene enet driver to re-balance
 IRQ usage

From: Al Stone <ahs3@...hat.com>
Date: Mon, 17 Sep 2018 17:35:33 -0600

> @@ -866,8 +866,11 @@ static int xgene_enet_napi(struct napi_struct *napi, const int budget)
>  	processed = xgene_enet_process_ring(ring, budget);
>  
>  	if (processed != budget) {
> +		struct irq_desc *desc = irq_to_desc(ring->irq);
> +
>  		napi_complete_done(napi, processed);
> -		enable_irq(ring->irq);
> +		if (desc && desc->depth > 0)
> +			enable_irq(ring->irq);

I really can't accept a patch that grovels into IRQ layer internals
to work around a driver's IRQ enable/disable usage problem.

Sorry.