linux-kernel - Re: [PATCH net] net: mvpp2: fix a txq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180918.201401.955097214067299890.davem@redhat.com>
Date:   Tue, 18 Sep 2018 20:14:01 -0700 (PDT)
From:   David Miller <davem@...hat.com>
To:     antoine.tenart@...tlin.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        thomas.petazzoni@...tlin.com, maxime.chevallier@...tlin.com,
        gregory.clement@...tlin.com, miquel.raynal@...tlin.com,
        nadavh@...vell.com, stefanc@...vell.com, ymarkman@...vell.com,
        mw@...ihalf.com
Subject: Re: [PATCH net] net: mvpp2: fix a txq_done race condition

From: Antoine Tenart <antoine.tenart@...tlin.com>
Date: Tue, 18 Sep 2018 16:58:47 +0200

> When no Tx IRQ is available, the txq_done() routine (called from
> tx_done()) shouldn't be called from the polling function, as in such
> case it is already called in the Tx path thanks to an hrtimer. This
> mostly occurred when using PPv2.1, as the engine then do not have Tx
> IRQs.
> 
> Fixes: edc660fa09e2 ("net: mvpp2: replace TX coalescing interrupts with hrtimer")
> Reported-by: Stefan Chulski <stefanc@...vell.com>
> Signed-off-by: Antoine Tenart <antoine.tenart@...tlin.com>

Applied and queued up for -stable.