linux-kernel - Re: [PATCH] samples: disable CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAQrOhJpkUf=zxvwcbf8oWTAhKiWxemweHz8QPT55H+R-g@mail.gmail.com>
Date:   Wed, 19 Sep 2018 15:58:40 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Richard Weinberger <richard@....at>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Jeff Dike <jdike@...toit.com>, linux-um@...ts.infradead.org,
        David Howells <dhowells@...hat.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Andy Gross <andy.gross@...aro.org>,
        Alex Williamson <alex.williamson@...hat.com>,
        Gerd Hoffmann <kraxel@...hat.com>
Subject: Re: [PATCH] samples: disable CONFIG_SAMPLES for UML

Hi.

2018-09-18 17:21 GMT+09:00 Richard Weinberger <richard@....at>:
> Am Dienstag, 18. September 2018, 05:58:33 CEST schrieb Masahiro Yamada:
>> Some samples require headers installation, so commit 3fca1700c4c3
>> ("kbuild: make samples really depend on headers_install") added
>> such dependency in the top Makefile.  However, UML fails to build
>> with CONFIG_SAMPLES=y because UML does not support headers_install.
>>
>> Fixes: 3fca1700c4c3 ("kbuild: make samples really depend on headers_install")
>> Reported-by: Kees Cook <keescook@...omium.org>
>> Cc: David Howells <dhowells@...hat.com>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>
> Is there anything UML can do better?
> Not sure whether an arch like is supposed to install headers at all,
> I guess no. :)

I just thought suppressing CONFIG_SAMPLES was a big hammer.

We could install host-arch headers for UML if we like,
but I am not sure whether is is sensible...

Wait for comments in case somebody has a better solution.





-- 
Best Regards
Masahiro Yamada