linux-kernel - Re: [PATCH] PCI: kirin: Fix section mismatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Sep 2018 11:29:44 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Nathan Chancellor <natechancellor@...il.com>,
        Xiaowei Song <songxiaowei@...ilicon.com>,
        Binghui Wang <wangbinghui@...ilicon.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH] PCI: kirin: Fix section mismatch warning

Xiaowei, Binghui,

On Tue, Sep 18, 2018 at 10:38:29PM -0700, Nathan Chancellor wrote:
> WARNING: vmlinux.o(.text+0x4758cc): Section mismatch in reference from
> the function kirin_pcie_probe() to the function
> .init.text:kirin_add_pcie_port()
> The function kirin_pcie_probe() references
> the function __init kirin_add_pcie_port().
> This is often because kirin_pcie_probe lacks a __init
> annotation or the annotation of kirin_add_pcie_port is wrong.
> 
> Remove '__init' from kirin_add_pcie_port so there is no mismatch.

I think that instead of removing __init section tag we should add
it to kirin_pcie_probe().

Please let me know and ACK accordingly.

Lorenzo

> Fixes: fc5165db245a ("PCI: kirin: Add HiSilicon Kirin SoC PCIe controller driver")
> Reported-by: Nick Desaulniers <ndesaulniers@...gle.com>
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
>  drivers/pci/controller/dwc/pcie-kirin.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controller/dwc/pcie-kirin.c
> index 5352e0c3be82..9b599296205d 100644
> --- a/drivers/pci/controller/dwc/pcie-kirin.c
> +++ b/drivers/pci/controller/dwc/pcie-kirin.c
> @@ -467,8 +467,8 @@ static int kirin_pcie_add_msi(struct dw_pcie *pci,
>  	return 0;
>  }
>  
> -static int __init kirin_add_pcie_port(struct dw_pcie *pci,
> -				      struct platform_device *pdev)
> +static int kirin_add_pcie_port(struct dw_pcie *pci,
> +			       struct platform_device *pdev)
>  {
>  	int ret;
>  
> -- 
> 2.19.0
>