linux-kernel - Re: [PATCH] media: dvb-frontends: Use kmemdup instead of duplicating its function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5BA1A6D0.4090506@huawei.com>
Date:   Wed, 19 Sep 2018 09:30:56 +0800
From:   zhong jiang <zhongjiang@...wei.com>
To:     Michael Ira Krufky <mkrufky@...uxtv.org>
CC:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Brad Love <brad@...tdimension.cc>,
        linux-media <linux-media@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: dvb-frontends: Use kmemdup instead of duplicating
 its function

On 2018/9/19 3:58, Michael Ira Krufky wrote:
> On Tue, Sep 18, 2018 at 11:42 AM zhong jiang <zhongjiang@...wei.com> wrote:
>> kmemdup has implemented the function that kmalloc() + memcpy().
>> We prefer to kmemdup rather than code opened implementation.
>>
>> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
>> ---
>>  drivers/media/dvb-frontends/lgdt3306a.c | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/media/dvb-frontends/lgdt3306a.c b/drivers/media/dvb-frontends/lgdt3306a.c
>> index 0e1f5da..abec2e5 100644
>> --- a/drivers/media/dvb-frontends/lgdt3306a.c
>> +++ b/drivers/media/dvb-frontends/lgdt3306a.c
>> @@ -2205,15 +2205,13 @@ static int lgdt3306a_probe(struct i2c_client *client,
>>         struct dvb_frontend *fe;
>>         int ret;
>>
>> -       config = kzalloc(sizeof(struct lgdt3306a_config), GFP_KERNEL);
>> +       onfig = kmemdup(client->dev.platform_data,
>> +                       sizeof(struct lgdt3306a_config), GFP_KERNEL);
>>         if (config == NULL) {
>>                 ret = -ENOMEM;
>>                 goto fail;
>>         }
>>
>> -       memcpy(config, client->dev.platform_data,
>> -                       sizeof(struct lgdt3306a_config));
>> -
>>         config->i2c_addr = client->addr;
>>         fe = lgdt3306a_attach(config, client->adapter);
>>         if (fe == NULL) {
> Thank you for this patch, Zhong.  I suspect, however, that the patch
> might contain a typo.  It looks like the `c` got dropped off of the
> `config` variable.
I am sorry.  It's my fault.:-[ . Will repost

Thanks,
zhong jiang
> Did you test this before sending it in?
>
> Thanks again and best regards,
>
> Michael Krufky
>
> .
>