linux-kernel - [tip:x86/urgent] x86/paravirt: Fix some warning messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <tip-571d0563c8881595f4ab027aef9ed1c55e3e7b7c@git.kernel.org>
Date:   Wed, 19 Sep 2018 04:27:50 -0700
From:   tip-bot for Dan Carpenter <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     hpa@...or.com, jgross@...e.com, dan.carpenter@...cle.com,
        tglx@...utronix.de, linux-kernel@...r.kernel.org, mingo@...nel.org,
        akataria@...are.com, peterz@...radead.org
Subject: [tip:x86/urgent] x86/paravirt: Fix some warning messages

Commit-ID:  571d0563c8881595f4ab027aef9ed1c55e3e7b7c
Gitweb:     https://git.kernel.org/tip/571d0563c8881595f4ab027aef9ed1c55e3e7b7c
Author:     Dan Carpenter <dan.carpenter@...cle.com>
AuthorDate: Wed, 19 Sep 2018 13:35:53 +0300
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Wed, 19 Sep 2018 13:22:04 +0200

x86/paravirt: Fix some warning messages

The first argument to WARN_ONCE() is a condition.

Fixes: 5800dc5c19f3 ("x86/paravirt: Fix spectre-v2 mitigations for paravirt guests")
Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Reviewed-by: Juergen Gross <jgross@...e.com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Alok Kataria <akataria@...are.com>
Cc: "H. Peter Anvin" <hpa@...or.com>
Cc: virtualization@...ts.linux-foundation.org
Cc: kernel-janitors@...r.kernel.org
Link: https://lkml.kernel.org/r/20180919103553.GD9238@mwanda


---
 arch/x86/kernel/paravirt.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/paravirt.c b/arch/x86/kernel/paravirt.c
index afdb303285f8..8dc69d82567e 100644
--- a/arch/x86/kernel/paravirt.c
+++ b/arch/x86/kernel/paravirt.c
@@ -91,7 +91,7 @@ unsigned paravirt_patch_call(void *insnbuf,
 
 	if (len < 5) {
 #ifdef CONFIG_RETPOLINE
-		WARN_ONCE("Failing to patch indirect CALL in %ps\n", (void *)addr);
+		WARN_ONCE(1, "Failing to patch indirect CALL in %ps\n", (void *)addr);
 #endif
 		return len;	/* call too long for patch site */
 	}
@@ -111,7 +111,7 @@ unsigned paravirt_patch_jmp(void *insnbuf, const void *target,
 
 	if (len < 5) {
 #ifdef CONFIG_RETPOLINE
-		WARN_ONCE("Failing to patch indirect JMP in %ps\n", (void *)addr);
+		WARN_ONCE(1, "Failing to patch indirect JMP in %ps\n", (void *)addr);
 #endif
 		return len;	/* call too long for patch site */
 	}