linux-kernel - Re: [PATCH] tools: Remove conflicting BITS_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <822a52db-93f1-3681-29ba-595cd000b5cd@nokia.com>
Date:   Wed, 19 Sep 2018 14:16:03 +0200
From:   Alexander Sverdlin <alexander.sverdlin@...ia.com>
To:     Arnaldo Carvalho de Melo <acme@...hat.com>
CC:     <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] tools: Remove conflicting BITS_PER_LONG define

On 12/09/2018 21:01, Arnaldo Carvalho de Melo wrote:
>>   CC       .../tools/objtool/builtin-check.o
>>   ...
>> In file included from .../tools/arch/x86/include/uapi/asm/bitsperlong.h:11:0,
>>                  from .../tools/include/asm-generic/bitops/__ffs.h:6,
>>                  from .../tools/include/asm-generic/bitops.h:16,
>>                  from .../tools/include/linux/bitops.h:35,
>>                  from .../tools/include/linux/hashtable.h:13,
>>                  from elf.h:24,
>>                  from check.h:22,
>>                  from builtin-check.c:30:
>> .../tools/include/asm-generic/bitsperlong.h:8:0: error: "BITS_PER_LONG" redefined [-Werror]
>>  #define BITS_PER_LONG (__CHAR_BIT__ * __SIZEOF_LONG__)
>>
>> Include <asm/bitsperlong.h> instead as other headers do.
> Please try test building all tools in tools/
> 
> This broke make -C tools/perf/

I agree, this brakes perf, so we need to work further on that...

-- 
Best regards,
Alexander Sverdlin.