linux-kernel - Re: [PATCH 2/2] video: ssd1307fb: Do not hard code active-low reset sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4830b2da-c487-f060-b876-d4d0e079c7d5@ysoft.com>
Date:   Wed, 19 Sep 2018 14:57:34 +0200
From:   Michal Vokáč <michal.vokac@...ft.com>
To:     Fabio Estevam <festevam@...il.com>
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Fabio Estevam <fabio.estevam@....com>,
        Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-fbdev@...r.kernel.org
Subject: Re: [PATCH 2/2] video: ssd1307fb: Do not hard code active-low reset
 sequence

On 19.9.2018 14:12, Fabio Estevam wrote:
> Hi Michal,
> 
> On Wed, Sep 19, 2018 at 6:18 AM, Michal Vokáč <michal.vokac@...ft.com> wrote:
>> The SSD130x OLED display reset signal is active low. Now the reset
>> sequence is implemented in such a way that users are forced to
>> define reset-gpios as GPIO_ACTIVE_HIGH in DT to make the reset work.
>>
>> Do not hard code the active-low sequence into the driver but instead
>> allow the user to specify the gpio as GPIO_ACTIVE_LOW to reflect
>> the real world.
>>
>> The only single in-tree user of the display is converted and builds
>> fine.
>>
>> Signed-off-by: Michal Vokáč <michal.vokac@...ft.com>
>> ---
>> I am not really sure wheater this should be in one commit or the DT
>> changes should be done in separate commit. Just tell me and I will
>> split/merge the changes as you want. Thanks.
> 
> Please separate in two patches: one for the dts and another for the driver.

OK, thank you. I will send v2 shortly.

Michal