linux-kernel - Re: [PATCH 5/6] staging: erofs: add some comments for xattr subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Sep 2018 23:27:27 +0800
From:   Chao Yu <chao@...nel.org>
To:     Gao Xiang <gaoxiang25@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Chao Yu <yuchao0@...wei.com>, devel@...verdev.osuosl.org
Cc:     Miao Xie <miaoxie@...wei.com>, linux-erofs@...ts.ozlabs.org,
        LKML <linux-kernel@...r.kernel.org>, Du Wei <weidu.du@...wei.com>
Subject: Re: [PATCH 5/6] staging: erofs: add some comments for xattr subsystem

On 2018/9/19 13:49, Gao Xiang wrote:
> As Dan Carpenter pointed out, it is better to document what
> return values of these callbacks in `struct xattr_iter_handlers'
> mean and why it->ofs is increased regardless of success or
> failure in `xattr_foreach'.
> 
> Suggested-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Gao Xiang <gaoxiang25@...wei.com>
> ---

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,