linux-kernel - Re: [PATCH 5/5] media: platform: dwc: Add MIPI CSI-2 controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 19 Sep 2018 16:03:13 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Luis Oliveira <Luis.Oliveira@...opsys.com>
Cc:     linux-media <linux-media@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        all-jpinto-org-pt02@...opsys.com,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Hans Verkuil <hans.verkuil@...co.com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Jacob Chen <jacob-chen@...wrt.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Thierry Reding <treding@...dia.com>,
        Maxime Ripard <maxime.ripard@...tlin.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Todor Tomov <todor.tomov@...aro.org>
Subject: Re: [PATCH 5/5] media: platform: dwc: Add MIPI CSI-2 controller driver

Hi Luis,

On Fri, Sep 14, 2018 at 7:48 PM, Luis Oliveira
<Luis.Oliveira@...opsys.com> wrote:

> +++ b/drivers/media/platform/dwc/dw-csi-plat.c
> @@ -0,0 +1,508 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later

According to Documentation/process/license-rules.rst this should be:
// SPDX-License-Identifier: GPL-2.0+

> +static int
> +dw_mipi_csi_parse_dt(struct platform_device *pdev, struct mipi_csi_dev *dev)
> +{
> +       struct device_node *node = pdev->dev.of_node;
> +       struct v4l2_fwnode_endpoint endpoint;
> +       int ret = 0;

No need to assign ret to 0.

> +
> +       ret = of_property_read_u32(node, "snps,output-type", &dev->hw.output);

> --- /dev/null
> +++ b/drivers/media/platform/dwc/dw-csi-plat.h
> @@ -0,0 +1,76 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */

Same as before.

> diff --git a/drivers/media/platform/dwc/dw-mipi-csi.c b/drivers/media/platform/dwc/dw-mipi-csi.c
> new file mode 100644
> index 0000000..926b287
> --- /dev/null
> +++ b/drivers/media/platform/dwc/dw-mipi-csi.c
> @@ -0,0 +1,491 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later

Ditto.

> +void dw_mipi_csi_fill_timings(struct mipi_csi_dev *dev,
> +                          const struct v4l2_bt_timings *bt)
> +{
> +

No need for this empty line.

> +       if (bt == NULL)

> diff --git a/drivers/media/platform/dwc/dw-mipi-csi.h b/drivers/media/platform/dwc/dw-mipi-csi.h
> new file mode 100644
> index 0000000..eca0e48
> --- /dev/null
> +++ b/drivers/media/platform/dwc/dw-mipi-csi.h
> @@ -0,0 +1,202 @@
> +/* SPDX-License-Identifier: GPL-2.0-or-later */

Ditto.