linux-kernel - Re: [PATCH v2] cpufreq: qcom-kryo: Fix section mismatch warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180919215418.y2jsrsj73vy3dudd@vireshk-mac-ubuntu>
Date:   Wed, 19 Sep 2018 14:54:18 -0700
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     Nathan Chancellor <natechancellor@...il.com>, ilia.lin@...il.com,
        rjw@...ysocki.net, linux-pm@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] cpufreq: qcom-kryo: Fix section mismatch warning

On 19-09-18, 14:50, Viresh Kumar wrote:
> On 19-09-18, 14:45, Nick Desaulniers wrote:
> > On Wed, Sep 19, 2018 at 11:22 AM Nathan Chancellor
> > <natechancellor@...il.com> wrote:
> > >
> > > WARNING: vmlinux.o(.text+0x8aa424): Section mismatch in reference from
> > > the function qcom_cpufreq_kryo_probe() to the function
> > > .init.text:qcom_cpufreq_kryo_get_msm_id()
> > > The function qcom_cpufreq_kryo_probe() references
> > > the function __init qcom_cpufreq_kryo_get_msm_id().
> > > This is often because qcom_cpufreq_kryo_probe lacks a __init
> > > annotation or the annotation of qcom_cpufreq_kryo_get_msm_id is wrong.
> > >
> > > Add the '__init' annotation to qcom_cpufreq_kryo_probe so that there is
> > > no more mismatch warning.
> > 
> > I wonder why this driver has an exit function marked __init rather
> > than __exit?
> 
> I think it was just a mistake.
> 
> > Does that mean it gets cleaned up after kernel init, and
> > so on unloading of the driver, the kernel jumps to unmapped memory?
> 
> The __init/exit sections are only useful when the driver is builtin
> and so there is no unloading. Yeah, if you would have tried to call
> shutdown for the kernel, it may have crashed or something. I don't
> know.
> 
> > Does this patch now produce a warning for `qcom_cpufreq_kryo_driver`
> > referencing `qcom_cpufreq_kryo_probe`?
> 
> Why should it ? It doesn't though.

I thought you replied to my commit where I marked the exit routine
with __exit and realised just now that it wasn't the case. I haven't
build-tested this thing, but the question still stands. Why should it
?

-- 
viresh