linux-kernel - Re: [PATCH] f2fs: fix to recover inode's uid/gid during POR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180920214130.GC35918@jaegeuk-macbookpro.roam.corp.google.com>
Date:   Thu, 20 Sep 2018 14:41:30 -0700
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     Chao Yu <yuchao0@...wei.com>
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, chao@...nel.org
Subject: Re: [PATCH] f2fs: fix to recover inode's uid/gid during POR

On 09/20, Chao Yu wrote:
> Step to reproduce this bug:
> 1. logon as root
> 2. mount -t f2fs /dev/sdd /mnt;
> 3. touch /mnt/file;
> 4. chown system /mnt/file; chgrp system /mnt/file;
> 5. xfs_io -f /mnt/file -c "fsync";
> 6. godown /mnt;
> 7. umount /mnt;
> 8. mount -t f2fs /dev/sdd /mnt;
> 
> After step 8) we will expect file's uid/gid are all system, but during
> recovery, these two fields were not been recovered, fix it.

Hmm, I tried this before, but wasn't enough to fix everything. :(

> 
> Signed-off-by: Chao Yu <yuchao0@...wei.com>
> ---
>  fs/f2fs/recovery.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
> index ba678efe7cad..da9f59b9044e 100644
> --- a/fs/f2fs/recovery.c
> +++ b/fs/f2fs/recovery.c
> @@ -209,6 +209,8 @@ static void recover_inode(struct inode *inode, struct page *page)
>  	char *name;
>  
>  	inode->i_mode = le16_to_cpu(raw->i_mode);
> +	i_uid_write(inode, le32_to_cpu(raw->i_uid));
> +	i_gid_write(inode, le32_to_cpu(raw->i_gid));
>  	f2fs_i_size_write(inode, le64_to_cpu(raw->i_size));
>  	inode->i_atime.tv_sec = le64_to_cpu(raw->i_atime);
>  	inode->i_ctime.tv_sec = le64_to_cpu(raw->i_ctime);
> -- 
> 2.18.0.rc1