linux-kernel - Re: [PATCH 10/12][RFC v3] x86-32, hibernate: Switch to relocated restore code during resume on 32bit system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180920220553.GL27468@xo-6d-61-c0.localdomain>
Date:   Fri, 21 Sep 2018 00:05:53 +0200
From:   Pavel Machek <pavel@....cz>
To:     Chen Yu <yu.c.chen@...el.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>, x86@...nel.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        Len Brown <len.brown@...el.com>,
        Zhimin Gu <kookoo.gu@...el.com>
Subject: Re: [PATCH 10/12][RFC v3] x86-32, hibernate: Switch to relocated
 restore code during resume on 32bit system

On Wed 2018-09-19 15:43:12, Chen Yu wrote:
> From: Zhimin Gu <kookoo.gu@...el.com>
> 
> Code should be executed in a safe page during page
> restoring, as the page where instruction is running
> during resume might be scribbled and causes issues.
> 
> Backport the code from 64 bit system to fix this bug.

On 32 bit, we only suspend resuming by same kernel that did the suspend.

64 bit does not have that restriction. So 32 bit code should not be actually
bugy.

> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Signed-off-by: Zhimin Gu <kookoo.gu@...el.com>
> Signed-off-by: Chen Yu <yu.c.chen@...el.com>

But we'd like to remove that restriction in future, so:

Acked-by: Pavel Machek <pavel@....cz>