linux-kernel - Re: [PATCH] power: supply: bq25890_charger: fix semicolon.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180920000901.45mhrxwhqfuzxjp7@earth.universe>
Date:   Thu, 20 Sep 2018 02:09:01 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     kbuild test robot <fengguang.wu@...el.com>
Cc:     "Angus Ainslie (Purism)" <angus@...ea.ca>, kbuild-all@...org,
        Krzysztof Kozlowski <krzk@...nel.org>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: bq25890_charger: fix semicolon.cocci
 warnings

Hi,

On Mon, Sep 17, 2018 at 10:23:20AM +0800, kbuild test robot wrote:
> From: kbuild test robot <fengguang.wu@...el.com>
> 
> drivers/power/supply/bq25890_charger.c:614:2-3: Unneeded semicolon
> drivers/power/supply/bq25890_charger.c:621:2-3: Unneeded semicolon
> drivers/power/supply/bq25890_charger.c:630:3-4: Unneeded semicolon
> drivers/power/supply/bq25890_charger.c:638:2-3: Unneeded semicolon
> drivers/power/supply/bq25890_charger.c:644:2-3: Unneeded semicolon
> 
> 
>  Remove unneeded semicolon.
> 
> Generated by: scripts/coccinelle/misc/semicolon.cocci
> 
> Fixes: 9d9ae3414d1b ("power: supply: bq25890_charger: Add debugging output of failed initialization")
> CC: Angus Ainslie (Purism) <angus@...ea.ca>
> Signed-off-by: kbuild test robot <fengguang.wu@...el.com>
> ---

Thanks, queued.

-- Sebastian

> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
> head:   cb90a2c6f77fe9b43d1e3f759bb2f13fe7fa1811
> commit: 9d9ae3414d1bb655d8db7079e56b0f51e7cd07f0 [4/13] power: supply: bq25890_charger: Add debugging output of failed initialization
> 
>  bq25890_charger.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> --- a/drivers/power/supply/bq25890_charger.c
> +++ b/drivers/power/supply/bq25890_charger.c
> @@ -611,14 +611,14 @@ static int bq25890_hw_init(struct bq2589
>  	if (ret < 0) {
>  		dev_dbg(bq->dev, "Reset failed %d\n", ret);
>  		return ret;
> -	};
> +	}
>  
>  	/* disable watchdog */
>  	ret = bq25890_field_write(bq, F_WD, 0);
>  	if (ret < 0) {
>  		dev_dbg(bq->dev, "Disabling watchdog failed %d\n", ret);
>  		return ret;
> -	};
> +	}
>  
>  	/* initialize currents/voltages and other parameters */
>  	for (i = 0; i < ARRAY_SIZE(init_data); i++) {
> @@ -627,7 +627,7 @@ static int bq25890_hw_init(struct bq2589
>  		if (ret < 0) {
>  			dev_dbg(bq->dev, "Writing init data failed %d\n", ret);
>  			return ret;
> -		};
> +		}
>  	}
>  
>  	/* Configure ADC for continuous conversions. This does not enable it. */
> @@ -635,13 +635,13 @@ static int bq25890_hw_init(struct bq2589
>  	if (ret < 0) {
>  		dev_dbg(bq->dev, "Config ADC failed %d\n", ret);
>  		return ret;
> -	};
> +	}
>  
>  	ret = bq25890_get_chip_state(bq, &state);
>  	if (ret < 0) {
>  		dev_dbg(bq->dev, "Get state failed %d\n", ret);
>  		return ret;
> -	};
> +	}
>  
>  	mutex_lock(&bq->lock);
>  	bq->state = state;

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)