linux-kernel - Re: [PATCH] ALSA: xen-front: Refine indentations and constify snd_pcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33d4fea3-70ff-e488-cd10-3abeb274fe3b@epam.com>
Date:   Thu, 20 Sep 2018 08:18:02 +0300
From:   Oleksandr Andrushchenko <Oleksandr_Andrushchenko@...m.com>
To:     Nick Simonov <nicksimonovv@...il.com>
Cc:     tiwai@...e.com, xen-devel@...ts.xenproject.org,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: xen-front: Refine indentations and constify
 snd_pcm_ops

On 09/20/2018 12:47 AM, Nick Simonov wrote:
> snd_pcm_ops are not supposed to change. So mark the
> non-const structs as const. Also, refine indentation
> to ncrease readability.
>
> Signed-off-by: Nick Simonov <nicksimonovv@...il.com>
> ---
>   sound/xen/xen_snd_front_alsa.c | 46 +++++++++++++++++++++---------------------
>   1 file changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
> index 129180e..2cbd967 100644
> --- a/sound/xen/xen_snd_front_alsa.c
> +++ b/sound/xen/xen_snd_front_alsa.c
> @@ -637,31 +637,31 @@ static int alsa_pb_fill_silence(struct snd_pcm_substream *substream,
>    * to know when the buffer can be transferred to the backend.
>    */
>   
> -static struct snd_pcm_ops snd_drv_alsa_playback_ops = {
> -	.open = alsa_open,
> -	.close = alsa_close,
> -	.ioctl = snd_pcm_lib_ioctl,
> -	.hw_params = alsa_hw_params,
> -	.hw_free = alsa_hw_free,
> -	.prepare = alsa_prepare,
> -	.trigger = alsa_trigger,
> -	.pointer = alsa_pointer,
> -	.copy_user = alsa_pb_copy_user,
> -	.copy_kernel = alsa_pb_copy_kernel,
> -	.fill_silence = alsa_pb_fill_silence,
> +static const struct snd_pcm_ops snd_drv_alsa_playback_ops = {
> +	.open		= alsa_open,
> +	.close		= alsa_close,
> +	.ioctl		= snd_pcm_lib_ioctl,
> +	.hw_params	= alsa_hw_params,
> +	.hw_free	= alsa_hw_free,
> +	.prepare	= alsa_prepare,
> +	.trigger	= alsa_trigger,
> +	.pointer	= alsa_pointer,
> +	.copy_user	= alsa_pb_copy_user,
> +	.copy_kernel	= alsa_pb_copy_kernel,
> +	.fill_silence	= alsa_pb_fill_silence,
>   };
>   
> -static struct snd_pcm_ops snd_drv_alsa_capture_ops = {
> -	.open = alsa_open,
> -	.close = alsa_close,
> -	.ioctl = snd_pcm_lib_ioctl,
> -	.hw_params = alsa_hw_params,
> -	.hw_free = alsa_hw_free,
> -	.prepare = alsa_prepare,
> -	.trigger = alsa_trigger,
> -	.pointer = alsa_pointer,
> -	.copy_user = alsa_cap_copy_user,
> -	.copy_kernel = alsa_cap_copy_kernel,
> +static const struct snd_pcm_ops snd_drv_alsa_capture_ops = {
> +	.open		= alsa_open,
> +	.close		= alsa_close,
> +	.ioctl		= snd_pcm_lib_ioctl,
> +	.hw_params	= alsa_hw_params,
> +	.hw_free	= alsa_hw_free,
> +	.prepare	= alsa_prepare,
> +	.trigger	= alsa_trigger,
> +	.pointer	= alsa_pointer,
> +	.copy_user	= alsa_cap_copy_user,
> +	.copy_kernel	= alsa_cap_copy_kernel,
>   };
>   
>   static int new_pcm_instance(struct xen_snd_front_card_info *card_info,
Thank you for the patch,
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@...m.com>