linux-kernel - Re: [PATCH] media: qcom: remove duplicated include file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43b41757-18ea-cbb3-1578-ba4068b13ab1@linaro.org>
Date:   Wed, 19 Sep 2018 22:55:03 -0700
From:   Todor Tomov <todor.tomov@...aro.org>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     mchehab@...nel.org, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: qcom: remove duplicated include file

Thank you for spotting that!

On 19.09.2018 21:59, zhong jiang wrote:
> device.h have duplicated include. hence just remove
> redundant include file.

I think it will be better to remove the second occurrence because
it will keep the alphabetical order of the includes.

Best regards,
Todor Tomov

> 
> Signed-off-by: zhong jiang <zhongjiang@...wei.com>
> ---
>  drivers/media/platform/qcom/camss/camss.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h
> index 418996d..0823a71 100644
> --- a/drivers/media/platform/qcom/camss/camss.h
> +++ b/drivers/media/platform/qcom/camss/camss.h
> @@ -10,7 +10,6 @@
>  #ifndef QC_MSM_CAMSS_H
>  #define QC_MSM_CAMSS_H
>  
> -#include <linux/device.h>
>  #include <linux/types.h>
>  #include <media/v4l2-async.h>
>  #include <media/v4l2-device.h>
>