linux-kernel - Re: [PATCH v2 2/5] scsi: libsas: check the lldd callback correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180920063409.GE12913@lst.de>
Date:   Thu, 20 Sep 2018 08:34:09 +0200
From:   Christoph Hellwig <hch@....de>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     martin.petersen@...cle.com, jejb@...ux.vnet.ibm.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        john.garry@...wei.com, zhaohongjiang@...wei.com, hare@...e.com,
        dan.j.williams@...el.com, jthumshirn@...e.de, hch@....de,
        huangdaode@...ilicon.com, chenxiang66@...ilicon.com,
        miaoxie@...wei.com, Ewan Milne <emilne@...hat.com>,
        Tomas Henzl <thenzl@...hat.com>
Subject: Re: [PATCH v2 2/5] scsi: libsas: check the lldd callback correctly

On Wed, Sep 19, 2018 at 11:32:01AM +0800, Jason Yan wrote:
> We are using lldd_port_deformed so we'd better check if lldd_port_deformed
> is NULL.
> 
> After this, we can remove hisi_sas_port_deformed() because it is just a
> stub to avoid a NULL dereference caused by the wrong check.
> 

The wording seems a bit odd.  I'd do something like:

libsas: make the lldd_port_deformed method optional

... and remove the dummy implementation in hisi_sas.


Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>