Message-ID: <CAB4CAwfAQvEV-DEW-A6bBgcYJB+HYe1JrFZam_eEwUQhmZHfuA@mail.gmail.com>
Date:   Thu, 20 Sep 2018 15:32:06 +0800
From:   Chris Chiu <chiu@...lessm.com>
To:     Jani Nikula <jani.nikula@...el.com>
Cc:     Ville Syrjälä <ville.syrjala@...ux.intel.com>,
        joonas.lahtinen@...ux.intel.com, rodrigo.vivi@...el.com,
        David Airlie <airlied@...ux.ie>,
        intel-gfx@...ts.freedesktop.org,
        Linux Upstreaming Team <linux@...lessm.com>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [BUG] i915 HDMI connector status is connected after disconnection

On Wed, Sep 19, 2018 at 8:08 PM, Jani Nikula <jani.nikula@...el.com> wrote:
> On Wed, 19 Sep 2018, Chris Chiu <chiu@...lessm.com> wrote:
>> I tried to add a slight delay in the hotplug work as follows
>>
>> --- a/drivers/gpu/drm/i915/intel_hotplug.c
>> +++ b/drivers/gpu/drm/i915/intel_hotplug.c
>> @@ -378,6 +378,8 @@ static void do_i915_hotplug_check(struct work_struct *work,
>>
>>         spin_unlock_irq(&dev_priv->irq_lock);
>>
>> +       msleep(100);
>> +
>>         drm_connector_list_iter_begin(dev, &conn_iter);
>>         drm_for_each_connector_iter(connector, &conn_iter) {
>>                 intel_connector = to_intel_connector(connector);
>>
>> It does work in most cases, but still fail to update the status if I
>> unplug the HDMI
>> cable very slow. I basically pull the HDMI cable in loose connected
>> state first, and
>> hold in that state ~1 second, totally unplug after that. The status in
>> sysfs will report
>> connected as it used to. There was no problem when I tried the patch
>> https://bugs.freedesktop.org/show_bug.cgi?id=107125#c8
>>
>> I'll try to modify this patch a little bit and send upstream for
>> discussion later. Please
>> advise if any. Thanks.
>
> Please let's not add excessive msleeps in work functions.
>
> My idea was more along the lines of making the hotplug function run in a
> delayed work. After a chat with Ville, below is what I came up with.
>
> Please let me know how it works. Feel free to toy with the
> delay. However, 1-2 seconds or more seems too much.
>
> BR,
> Jani.
>

Thanks to the patch. It works in most cases on my problematic laptops.
After lots
of experiments, ex. pull the cable out with different paces, range
delay from 300 to
800 msec, it makes no significant difference for a longer delay. So
300 msec is good
enough for most cases. It at least updates the status correctly with a
visible quick
display blink when disconnecting HDMI. And compared to other machines which have
no such problem, the HDMI cable slow pull out also result in the same
problem. I'll
say the test result is OK for me. Thanks.

Chris

>
>
> From 72515b3e856171e52e96bb74796774f595a7f418 Mon Sep 17 00:00:00 2001
> From: Jani Nikula <jani.nikula@...el.com>
> Date: Tue, 18 Sep 2018 13:12:34 +0300
> Subject: [PATCH] drm/i915: delay hotplug scheduling
> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
> Cc: Jani Nikula <jani.nikula@...el.com>
>
> On some systems we get the hotplug irq on unplug before the DDC pins
> have been disconnected, resulting in connector status remaining
> connected. Since previous attempts at using hotplug live status before
> DDC have failed, the only viable option is to reduce the window for
> mistakes. Delay the hotplug processing.
>
> Signed-off-by: Jani Nikula <jani.nikula@...el.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.h      |  2 +-
>  drivers/gpu/drm/i915/intel_hotplug.c | 15 ++++++++++-----
>  2 files changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 7d4daa7412f1..27f579abddae 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -286,7 +286,7 @@ enum hpd_pin {
>  #define HPD_STORM_DEFAULT_THRESHOLD 5
>
>  struct i915_hotplug {
> -       struct work_struct hotplug_work;
> +       struct delayed_work hotplug_work;
>
>         struct {
>                 unsigned long last_jiffies;
> diff --git a/drivers/gpu/drm/i915/intel_hotplug.c b/drivers/gpu/drm/i915/intel_hotplug.c
> index 648a13c6043c..3af64daa5cfc 100644
> --- a/drivers/gpu/drm/i915/intel_hotplug.c
> +++ b/drivers/gpu/drm/i915/intel_hotplug.c
> @@ -110,6 +110,8 @@ enum hpd_pin intel_hpd_pin_default(struct drm_i915_private *dev_priv,
>         }
>  }
>
> +#define HOTPLUG_DELAY_MS               300
> +
>  #define HPD_STORM_DETECT_PERIOD                1000
>  #define HPD_STORM_REENABLE_DELAY       (2 * 60 * 1000)
>
> @@ -319,7 +321,8 @@ static void i915_digport_work_func(struct work_struct *work)
>                 spin_lock_irq(&dev_priv->irq_lock);
>                 dev_priv->hotplug.event_bits |= old_bits;
>                 spin_unlock_irq(&dev_priv->irq_lock);
> -               schedule_work(&dev_priv->hotplug.hotplug_work);
> +               schedule_delayed_work(&dev_priv->hotplug.hotplug_work,
> +                                     msecs_to_jiffies(HOTPLUG_DELAY_MS));
>         }
>  }
>
> @@ -329,7 +332,7 @@ static void i915_digport_work_func(struct work_struct *work)
>  static void i915_hotplug_work_func(struct work_struct *work)
>  {
>         struct drm_i915_private *dev_priv =
> -               container_of(work, struct drm_i915_private, hotplug.hotplug_work);
> +               container_of(work, struct drm_i915_private, hotplug.hotplug_work.work);
>         struct drm_device *dev = &dev_priv->drm;
>         struct intel_connector *intel_connector;
>         struct intel_encoder *intel_encoder;
> @@ -466,7 +469,8 @@ void intel_hpd_irq_handler(struct drm_i915_private *dev_priv,
>         if (queue_dig)
>                 queue_work(dev_priv->hotplug.dp_wq, &dev_priv->hotplug.dig_port_work);
>         if (queue_hp)
> -               schedule_work(&dev_priv->hotplug.hotplug_work);
> +               schedule_delayed_work(&dev_priv->hotplug.hotplug_work,
> +                                     msecs_to_jiffies(HOTPLUG_DELAY_MS));
>  }
>
>  /**
> @@ -586,7 +590,8 @@ void intel_hpd_poll_init(struct drm_i915_private *dev_priv)
>
>  void intel_hpd_init_work(struct drm_i915_private *dev_priv)
>  {
> -       INIT_WORK(&dev_priv->hotplug.hotplug_work, i915_hotplug_work_func);
> +       INIT_DELAYED_WORK(&dev_priv->hotplug.hotplug_work,
> +                         i915_hotplug_work_func);
>         INIT_WORK(&dev_priv->hotplug.dig_port_work, i915_digport_work_func);
>         INIT_WORK(&dev_priv->hotplug.poll_init_work, i915_hpd_poll_init_work);
>         INIT_DELAYED_WORK(&dev_priv->hotplug.reenable_work,
> @@ -604,7 +609,7 @@ void intel_hpd_cancel_work(struct drm_i915_private *dev_priv)
>         spin_unlock_irq(&dev_priv->irq_lock);
>
>         cancel_work_sync(&dev_priv->hotplug.dig_port_work);
> -       cancel_work_sync(&dev_priv->hotplug.hotplug_work);
> +       cancel_delayed_work_sync(&dev_priv->hotplug.hotplug_work);
>         cancel_work_sync(&dev_priv->hotplug.poll_init_work);
>         cancel_delayed_work_sync(&dev_priv->hotplug.reenable_work);
>  }
> --
> 2.11.0
>
>
> --
> Jani Nikula, Intel Open Source Graphics Center

Powered by blists - more mailing lists