[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <9c7cbfd4-23dc-4729-a7ca-82bbc8f6c1aa@ysoft.com>
Date: Thu, 20 Sep 2018 09:47:33 +0200
From: Michal Vokáč <michal.vokac@...ft.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
Shawn Guo <shawnguo@...nel.org>
Cc: Fabio Estevam <fabio.estevam@....com>,
Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-fbdev@...r.kernel.org
Subject: Re: [PATCH v2 1/3] video: ssd1307fb: Use gpiod_set_value_cansleep()
for reset
On 19.9.2018 15:17, Michal Vokáč wrote:
> The reset signal can be produced by GPIO expander that can sleep.
> In that case the probe function fails. Allow using GPIO expanders for
> the reset signal by using the non-atomic gpiod_set_value_cansleep()
> function.
>
> Signed-off-by: Michal Vokáč <michal.vokac@...ft.com>
I forgot to add R-by from Fabio from v1, sorry.
I made the respin in a hurry and skipped my pre-submission checklist..
Michal
> ---
> v2 changes: none
>
> drivers/video/fbdev/ssd1307fb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
> index ba66c02..e7ae135 100644
> --- a/drivers/video/fbdev/ssd1307fb.c
> +++ b/drivers/video/fbdev/ssd1307fb.c
> @@ -728,9 +728,9 @@ static int ssd1307fb_probe(struct i2c_client *client,
>
> if (par->reset) {
> /* Reset the screen */
> - gpiod_set_value(par->reset, 0);
> + gpiod_set_value_cansleep(par->reset, 0);
> udelay(4);
> - gpiod_set_value(par->reset, 1);
> + gpiod_set_value_cansleep(par->reset, 1);
> udelay(4);
> }
>
>
Powered by blists - more mailing lists