linux-kernel - Re: [PATCH 17/22] ACPI: implement acpi_handle_debug in terms of _dynamic_func

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3017961.RRfiJQt7az@aspire.rjw.lan>
Date:   Thu, 20 Sep 2018 10:05:30 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     Jason Baron <jbaron@...mai.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH 17/22] ACPI: implement acpi_handle_debug in terms of _dynamic_func_call

On Thursday, September 20, 2018 12:04:39 AM CEST Rasmus Villemoes wrote:
> With coming changes on x86-64, all dynamic debug descriptors in a
> translation unit must have distinct names. The macro _dynamic_func_call
> takes care of that. No functional change.
> 
> Cc: linux-acpi@...r.kernel.org
> Signed-off-by: Rasmus Villemoes <linux@...musvillemoes.dk>
> ---
>  include/linux/acpi.h | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/include/linux/acpi.h b/include/linux/acpi.h
> index e12d5ef1a054..83bacf9039e9 100644
> --- a/include/linux/acpi.h
> +++ b/include/linux/acpi.h
> @@ -977,12 +977,8 @@ void __acpi_handle_debug(struct _ddebug *descriptor, acpi_handle handle, const c
>  #else
>  #if defined(CONFIG_DYNAMIC_DEBUG)
>  #define acpi_handle_debug(handle, fmt, ...)				\
> -do {									\
> -	DEFINE_DYNAMIC_DEBUG_METADATA(descriptor, fmt);			\
> -	if (DYNAMIC_DEBUG_BRANCH(descriptor))				\
> -		__acpi_handle_debug(&descriptor, handle, pr_fmt(fmt),	\
> -				##__VA_ARGS__);				\
> -} while (0)
> +	_dynamic_func_call(fmt, __acpi_handle_debug,			\
> +			   handle, pr_fmt(fmt), ##__VA_ARGS__)
>  #else
>  #define acpi_handle_debug(handle, fmt, ...)				\
>  ({									\
> 

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>