linux-kernel - Re: [PATCH] zram: fix missing zero pages for memory tracking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180920111255.GA31303@rodete-laptop-imager.corp.google.com>
Date:   Thu, 20 Sep 2018 20:12:55 +0900
From:   Minchan Kim <minchan@...nel.org>
To:     Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        stable@...r.kernel.org
Subject: Re: [PATCH] zram: fix missing zero pages for memory tracking

Hi Sergey,

On Wed, Sep 19, 2018 at 04:29:16PM +0900, Sergey Senozhatsky wrote:
> On (09/19/18 14:18), Minchan Kim wrote:
> > We need to count zero filled pages as well as other pages in zram.
> 
> A nit,
> 
> 	'ZRAM_FLAG_SHIFT + 1' covers all ZRAM_SAME pages, not only
> zero filled pages.

Yub, that's what I want.
Currently, it covers only non-zero filled same page, which is
inconsistent and user easily miss zero-filled same page.