linux-kernel - Re: [PATCH v3 2/2] serial: uartps: Change uart ID port allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 Sep 2018 13:43:05 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michal Simek <michal.simek@...inx.com>
CC:     <linux-kernel@...r.kernel.org>, <monstr@...str.eu>,
        Jiri Slaby <jslaby@...e.com>, <linux-serial@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v3 2/2] serial: uartps: Change uart ID port allocation

On 20.9.2018 13:32, Greg Kroah-Hartman wrote:
> On Tue, Sep 18, 2018 at 04:57:59PM +0200, Michal Simek wrote:
>> For IPs which have alias algorightm all the time using that alias and
>> minor number. It means serial20 alias ends up as ttyPS20.
>>
>> If alias is not setup for probed IP instance the first unused position is
>> used but that needs to be checked if it is really empty because another
>> instance doesn't need to be probed at that time. of_alias_get_alias_list()
>> fills alias bitmap which exactly shows which ID is free.
>> If alias pointing to different not compatible IP, it is free to use.
>>
>> cdns_get_id() call is placed below structure allocation to simplify
>> error path.
>>
>> Signed-off-by: Michal Simek <michal.simek@...inx.com>
>> ---
>>
>> Changes in v3: None
>> Changes in v2:
>> - Add handle of return value from of_alias_get_alias_list
>>
>> Needs to be applied on the top of
>> https://lkml.org/lkml/2018/9/3/404
>> https://lkml.org/lkml/2018/9/3/400 (minor that's why just in case)
>>
>> Greg: Please apply it with
>> "of: base: Introduce of_alias_get_alias_list() to check alias IDs
>> Rob is ok with that.
> 
> I don't have that patch, can you resend the whole series?

done.
M