linux-kernel - Re: [PATCH] gpiolib: Show correct direction from the beginning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bcb79947-dfe0-e5e2-fb48-3b6992720f01@kernel.org>
Date:   Thu, 20 Sep 2018 07:35:52 -0500
From:   Timur Tabi <timur@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
        Stephen Boyd <swboyd@...omium.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpiolib: Show correct direction from the beginning

On 9/20/18 12:23 AM, Linus Walleij wrote:
> I think most gpiochips easily survives calling the .get_direction()
> early, Qualcomm's stand out here.
> 
> Now that we have .valid_mask in the gpiochip could we simply just
> add this back, resepecting valid_mask and avoid checking the
> direction of precisely these GPIOs?

Can you be more specific?  One of the proposals made previously was to 
add a check in msm_gpio_get_direction(), but that was rejected because 
the consensus was the valid_mask checks in gpiolib are sufficient.