linux-kernel - [PATCH net-next 12/22] net: ovs: fix return type of ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180920123306.14772-13-yuehaibing@huawei.com>
Date:   Thu, 20 Sep 2018 20:32:56 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     <davem@...emloft.net>, <dmitry.tarnyagin@...kless.no>,
        <wg@...ndegger.com>, <mkl@...gutronix.de>,
        <michal.simek@...inx.com>, <hsweeten@...ionengravers.com>,
        <madalin.bucur@....com>, <pantelis.antoniou@...il.com>,
        <claudiu.manoil@....com>, <leoyang.li@....com>,
        <linux@...linux.org.uk>, <sammy@...my.net>, <ralf@...ux-mips.org>,
        <nico@...xnic.net>, <steve.glendinning@...well.net>,
        <f.fainelli@...il.com>, <grygorii.strashko@...com>,
        <w-kwok2@...com>, <m-karicheri2@...com>, <t.sailer@...mni.ethz.ch>,
        <jreuter@...na.de>, <kys@...rosoft.com>, <haiyangz@...rosoft.com>,
        <wei.liu2@...rix.com>, <paul.durrant@...rix.com>,
        <arvid.brodin@...en.se>, <pshelar@....org>
CC:     <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-can@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linuxppc-dev@...ts.ozlabs.org>, <linux-mips@...ux-mips.org>,
        <linux-omap@...r.kernel.org>, <linux-hams@...r.kernel.org>,
        <devel@...uxdriverproject.org>, <linux-usb@...r.kernel.org>,
        <xen-devel@...ts.xenproject.org>, <dev@...nvswitch.org>,
        YueHaibing <yuehaibing@...wei.com>
Subject: [PATCH net-next 12/22] net: ovs: fix return type of ndo_start_xmit function

The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.

Found by coccinelle.

Signed-off-by: YueHaibing <yuehaibing@...wei.com>
---
 net/openvswitch/vport-internal_dev.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c
index bb95c43..26f71cb 100644
--- a/net/openvswitch/vport-internal_dev.c
+++ b/net/openvswitch/vport-internal_dev.c
@@ -43,7 +43,8 @@ static struct internal_dev *internal_dev_priv(struct net_device *netdev)
 }
 
 /* Called with rcu_read_lock_bh. */
-static int internal_dev_xmit(struct sk_buff *skb, struct net_device *netdev)
+static netdev_tx_t
+internal_dev_xmit(struct sk_buff *skb, struct net_device *netdev)
 {
 	int len, err;
 
@@ -62,7 +63,7 @@ static int internal_dev_xmit(struct sk_buff *skb, struct net_device *netdev)
 	} else {
 		netdev->stats.tx_errors++;
 	}
-	return 0;
+	return NETDEV_TX_OK;
 }
 
 static int internal_dev_open(struct net_device *netdev)
-- 
1.8.3.1