linux-kernel - Re: [PATCH] jfs: remove redundant dquot_initialize() in jfs_evict

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Sep 2018 09:24:53 -0500
From:   Dave Kleikamp <dave.kleikamp@...cle.com>
To:     Chao Yu <chao@...nel.org>, Chao Yu <yuchao0@...wei.com>,
        "open list:JFS FILESYSTEM" <jfs-discussion@...ts.sourceforge.net>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] jfs: remove redundant dquot_initialize() in
 jfs_evict_inode()

On 9/20/18 9:18 AM, Chao Yu wrote:
> Ping,
> 
> Any comments?

Sorry for putting it off. It looks good to me. I'll push it upstream.

Thanks,
Dave

> 
> On 2018/9/17 15:12, Chao Yu wrote:
>> We don't need to call dquot_initialize() twice in jfs_evict_inode(),
>> remove one of them for cleanup.
>>
>> Signed-off-by: Chao Yu <yuchao0@...wei.com>
>> ---
>>  fs/jfs/inode.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/jfs/inode.c b/fs/jfs/inode.c
>> index 054cc761b426..805ae9e8944a 100644
>> --- a/fs/jfs/inode.c
>> +++ b/fs/jfs/inode.c
>> @@ -166,7 +166,6 @@ void jfs_evict_inode(struct inode *inode)
>>  			/*
>>  			 * Free the inode from the quota allocation.
>>  			 */
>> -			dquot_initialize(inode);
>>  			dquot_free_inode(inode);
>>  		}
>>  	} else {
>>