linux-kernel - Re: [PATCH AUTOSEL 4.18 10/92] mtd: rawnand: fscm: Avoid collision on PC def when compiling for MIPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180920023257.GR3821@sasha-vm>
Date:   Thu, 20 Sep 2018 02:32:58 +0000
From:   Sasha Levin <Alexander.Levin@...rosoft.com>
To:     Miquel Raynal <miquel.raynal@...tlin.com>
CC:     "stable@...r.kernel.org" <stable@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Boris Brezillon <boris.brezillon@...tlin.com>
Subject: Re: [PATCH AUTOSEL 4.18 10/92] mtd: rawnand: fscm: Avoid collision on
 PC def when compiling for MIPS

On Sat, Sep 15, 2018 at 07:21:11PM +0200, Miquel Raynal wrote:
>Hi Sasha,
>
>Sasha Levin <Alexander.Levin@...rosoft.com> wrote on Sat, 15 Sep 2018
>01:29:55 +0000:
>
>> From: Boris Brezillon <boris.brezillon@...tlin.com>
>>
>> [ Upstream commit 8f3931ed975e1d775b87ce85d65ecacd54138359 ]
>>
>> We want to allow this driver to be selected when COMPILE_TEST=y, this
>> means the driver can be compiled for any arch, including MIPS. When
>> compiling this driver for MIPS, we end up with a collision on the 'PC'
>> macro definition (also defined in arch/mips/include/asm/ptrace.h).
>>
>> Prefix the fsmc one with FSMC_ to avoid this problem.
>>
>> Signed-off-by: Boris Brezillon <boris.brezillon@...tlin.com>
>> Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
>> Signed-off-by: Sasha Levin <alexander.levin@...rosoft.com>
>
>I don't know what the exact policy is regarding backporting patches to
>stable but this one, while harmless, will have no effect on
>stable kernels AFAICT because it fixes issues discovered when allowing
>COMPILE_TEST on a few drivers, which is a change that is not going to be
>stable materials anyway.
>
>Same situation for:
>[PATCH AUTOSEL 4.18 11/92] mtd: rawnand: sunxi: Add an U suffix to  NFC_PAGE_OP definition
>[PATCH AUTOSEL 4.14 08/57] mtd: rawnand: sunxi: Add an U suffix to  NFC_PAGE_OP definition
>[PATCH AUTOSEL 4.9 04/34] mtd: rawnand: sunxi: Add an U suffix to  NFC_PAGE_OP definition
>[PATCH AUTOSEL 4.4 04/20] mtd: rawnand: sunxi: Add an U suffix to  NFC_PAGE_OP definition

I'll drop it from all branches. Thanks!