linux-kernel - Re: [PATCH] pinctrl: qcom: spmi-gpio: Add pms405 gpio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180920163405.GE1367@tuxbook-pro>
Date:   Thu, 20 Sep 2018 09:34:05 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Stephen Boyd <sboyd@...nel.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: qcom: spmi-gpio: Add pms405 gpio support

On Thu 20 Sep 08:30 PDT 2018, Stephen Boyd wrote:

> Quoting Bjorn Andersson (2018-09-19 18:47:05)
> > diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> > index a29efbe08f48..b54891998caa 100644
> > --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> > +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> > @@ -1055,6 +1055,7 @@ static const struct of_device_id pmic_gpio_of_match[] = {
> >         { .compatible = "qcom,pm8994-gpio" },   /* 22 GPIO's */
> >         { .compatible = "qcom,pmi8994-gpio" },  /* 10 GPIO's */
> >         { .compatible = "qcom,pma8084-gpio" },  /* 22 GPIO's */
> > +       { .compatible = "qcom,pms405-gpio" }, /* 11 GPIO's */
> 
> I thought we didn't update the C driver, because there isn't anything to
> do here. Just make binding updates and it's all fine.
> 

Right, forgot that we just use the fallback.

Thanks,
Bjorn

> >         { .compatible = "qcom,spmi-gpio" }, /* Generic */
> >         { },
> >  };