linux-kernel - Re: [PATCH] IB/nes: Remove unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdnB32mZ900adeMmBpXTa6LjzAOooaGS+w96vkjZR=G_HQ@mail.gmail.com>
Date:   Thu, 20 Sep 2018 09:47:45 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     faisal.latif@...el.com, dledford@...hat.com, jgg@...pe.ca,
        linux-rdma@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] IB/nes: Remove unnecessary parentheses

On Wed, Sep 19, 2018 at 8:30 PM Nathan Chancellor
<natechancellor@...il.com> wrote:
>
> Clang warns when more than one set of parentheses are used in single
> conditional statements.
>
> drivers/infiniband/hw/nes/nes_hw.c:1446:27: warning: equality comparison
> with extraneous parentheses [-Wparentheses-equality]
>         } while ((temp_phy_data2 == temp_phy_data));
>                   ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
> drivers/infiniband/hw/nes/nes_hw.c:1446:27: note: remove extraneous
> parentheses around the comparison to silence this warning
>         } while ((temp_phy_data2 == temp_phy_data));
>                  ~               ^               ~
> drivers/infiniband/hw/nes/nes_hw.c:1446:27: note: use '=' to turn this
> equality comparison into an assignment
>         } while ((temp_phy_data2 == temp_phy_data));
>                                  ^~
>                                  =
>
> Remove the unnecessary parentheses to silence this warning.
>
> Reported-by: Nick Desaulniers <ndesaulniers@...gle.com>
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>
> ---
>  drivers/infiniband/hw/nes/nes_hw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/nes/nes_hw.c b/drivers/infiniband/hw/nes/nes_hw.c
> index bd0675d8f298..5517e392bc01 100644
> --- a/drivers/infiniband/hw/nes/nes_hw.c
> +++ b/drivers/infiniband/hw/nes/nes_hw.c
> @@ -1443,7 +1443,7 @@ static int nes_init_2025_phy(struct nes_device *nesdev, u8 phy_type, u8 phy_inde
>                 mdelay(1);
>                 nes_read_10G_phy_reg(nesdev, phy_index, 0x3, 0xd7ee);
>                 temp_phy_data2 = (u16)nes_read_indexed(nesdev, NES_IDX_MAC_MDIO_CONTROL);
> -       } while ((temp_phy_data2 == temp_phy_data));
> +       } while (temp_phy_data2 == temp_phy_data);
>
>         /* wait for tracking */
>         counter = 0;
> --
> 2.19.0
>

Nathan, thanks for this patch.
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>


-- 
Thanks,
~Nick Desaulniers