linux-kernel - Re: [PATCH] Don't hardcode path as it is architecture dependent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2232247.seiAqWBpkp@blindfold>
Date:   Thu, 20 Sep 2018 21:05:29 +0200
From:   Richard Weinberger <richard@....at>
To:     Ritesh Raj Sarraf <rrs@...ian.org>
Cc:     Ritesh Raj Sarraf <rrs@...earchut.com>,
        Jeff Dike <jdike@...toit.com>, linux-um@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Don't hardcode path as it is architecture dependent

Am Donnerstag, 20. September 2018, 08:26:38 CEST schrieb Ritesh Raj Sarraf:
> The current code fails to run on amd64 because of hardcoded reference to
> i386
> 
> Signed-off-by: Ritesh Raj Sarraf <rrs@...earchut.com>

Thanks for spotting this!

> ---
>  arch/um/drivers/port_user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/um/drivers/port_user.c b/arch/um/drivers/port_user.c
> index 9a8e1b64c22e..5f56d11b886f 100644
> --- a/arch/um/drivers/port_user.c
> +++ b/arch/um/drivers/port_user.c
> @@ -168,7 +168,7 @@ int port_connection(int fd, int *socket, int *pid_out)
>  {
>  	int new, err;
>  	char *argv[] = { "/usr/sbin/in.telnetd", "-L",
> -			 "/usr/lib/uml/port-helper", NULL };
> +			 OS_LIB_PATH "/uml/port-helper", NULL };
>  	struct port_pre_exec_data data;
>  
>  	new = accept(fd, NULL, 0);

Thanks,
//richard