linux-kernel - Re: [virtio-dev] [PATCH 2/2] drm/virtio: add iommu support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95778dd4-8aca-eff6-f84a-c8efdd3b355d@amd.com>
Date:   Fri, 21 Sep 2018 04:58:18 +0000
From:   Jiandi An <jiandi@....com>
To:     Gerd Hoffmann <kraxel@...hat.com>
CC:     Dave Airlie <airlied@...il.com>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        "virtio-dev@...ts.oasis-open.org" <virtio-dev@...ts.oasis-open.org>,
        Dave Airlie <airlied@...ux.ie>,
        "open list:VIRTIO CORE, NET..." 
        <virtualization@...ts.linux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "Lendacky, Thomas" <Thomas.Lendacky@....com>,
        "Singh, Brijesh" <brijesh.singh@....com>
Subject: Re: [virtio-dev] [PATCH 2/2] drm/virtio: add iommu support.



On 09/20/2018 01:32 AM, Gerd Hoffmann wrote:
>   Hi,
> 
>> void virtio_gpu_cmd_transfer_to_host_2d(struct virtio_gpu_device *vgdev,
>>                                         uint32_t resource_id, uint64_t offset,
>> ...
>>      struct virtio_gpu_fbdev *vgfbdev = vgdev->vgfbdev;
>>      struct virtio_gpu_framebuffer *fb = &vgfbdev->vgfb;
>>      struct virtio_gpu_object *obj = gem_to_virtio_gpu_obj(fb->base.obj[0]);
> 
> Ah, right.  Should have noticed this on review.  You sync the fbcon
> framebuffer unconfitionally ...
> 
>> Is there better way to get to the virtio_gpu_object created in the
>> virtio_gpu_mode_dumb_create() path from virtio_gpu_device or somehow from drm_file
>> via gem_handle down at the layer of virtio_gpu_cmd_transfer_to_host()?
> 
> Just pass it down, the call sites all know it (see patch just sent).

Tested that patch you sent.  Together with this patch it also resolves
the virtio gpu graphical display issue for SEV guest.

Is there a way to optimize the dma_sync_sg to only sync on the pages
being updated instead of all the pages in the obj sgl list every time?

Thanks.
- Jiandi

> 
> cheers,
>   Gerd
>