linux-kernel - Re: [PATCH 0/6] platform/x86: acerhdf: new BIOS string, better modparam handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f401b6fed813afb86f5442c7707bf9fb@piie.net>
Date:   Fri, 21 Sep 2018 06:20:27 +0000
From:   "Peter Feuerer" <peter@...e.net>
To:     "Paul Gortmaker" <paul.gortmaker@...driver.com>,
        platform-driver-x86@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, "Darren Hart" <dvhart@...radead.org>,
        "Andy Shevchenko" <andy@...radead.org>
Subject: Re: [PATCH 0/6] platform/x86: acerhdf: new BIOS string, better
 modparam handling

Hi,

21. September 2018 03:45, "Paul Gortmaker" <paul.gortmaker@...driver.com> schrieb:

> I came across this older netbook over the xmas holidays, and noticed the
> acerhdf driver wouldn't load. Turns out the BIOS string was too new,
> and not listed in the driver. There were module params for overrides,
> but I found their use isn't quite clear without reading the source.
> 
> Here I clarify some of the module parameter usage, and then add the new
> BIOS string, so they won't be needed for this particular platform. Some
> probe code is also shifted out to be __init to reduce the driver size a
> bit. Further details can be found in the respective commit logs.
> 
> Since it was months ago when I created these patches, I retested on top
> of tree to ensure things still work, as can be seen below.

Thanks a lot for your work and this set of changes.  This improves quality.
I reviewed all 6 patches.

Reviewed-by: Peter Feuerer <peter@...e.net>

Please also add CC: Boris Petkov <bp@...e.de> for review.

[...]

-- 
kind regards,
--peter;