linux-kernel - Re: [PATCH -next] drm/vkms: Fix possible memory leak in _vkms_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180921085031.GV11082@phenom.ffwll.local>
Date:   Fri, 21 Sep 2018 10:50:31 +0200
From:   Daniel Vetter <daniel@...ll.ch>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     David Airlie <airlied@...ux.ie>,
        Haneen Mohammed <hamohammed.sa@...il.com>,
        Sean Paul <seanpaul@...omium.org>,
        Mahesh Kumar <mahesh1.kumar@...el.com>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] drm/vkms: Fix possible memory leak in
 _vkms_get_crc()

On Sat, Sep 15, 2018 at 01:53:19AM +0000, Wei Yongjun wrote:
> 'vaddr_out' is malloced in _vkms_get_crc() and should be freed before
> leaving from the error handling cases, otherwise it will cause memory
> leak.
> 
> Fixes: db7f419c06d7 ("drm/vkms: Compute CRC with Cursor Plane")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Applied, thanks for your patch.
-Daniel

> ---
>  drivers/gpu/drm/vkms/vkms_crc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_crc.c b/drivers/gpu/drm/vkms/vkms_crc.c
> index 0a27456..9d9e814 100644
> --- a/drivers/gpu/drm/vkms/vkms_crc.c
> +++ b/drivers/gpu/drm/vkms/vkms_crc.c
> @@ -125,6 +125,7 @@ static uint32_t _vkms_get_crc(struct vkms_crc_data *primary_crc,
>  	mutex_lock(&vkms_obj->pages_lock);
>  	if (WARN_ON(!vkms_obj->vaddr)) {
>  		mutex_unlock(&vkms_obj->pages_lock);
> +		kfree(vaddr_out);
>  		return crc;
>  	}
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch