linux-kernel - Re: [PATCH 2/2] hwmon: ina3221: Get channel names from DT node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180921091813.GA21564@Asurada-Nvidia.nvidia.com>
Date:   Fri, 21 Sep 2018 02:18:14 -0700
From:   Nicolin Chen <nicoleotsuka@...il.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     jdelvare@...e.com, robh+dt@...nel.org, mark.rutland@....com,
        afd@...com, linux-hwmon@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] hwmon: ina3221: Get channel names from DT node

Hi,

On Thu, Sep 20, 2018 at 06:20:38PM -0700, Nicolin Chen wrote:
> > So if there are no devicetree entries, the user now gets a sequence of
> > "unknown" sensors ? I don't think so. Please keep in mind that there are
> > users of this chip who don't have devicetree systems, and other users
> > may not want to specify any specific name properties (or they use sensors3.conf
> > to do it).
> 
> Being enlightened by your comments below, maybe adding a
> separate group for channel names by attaching is_visible
> to it could be acceptable? Then, name nodes can hide from
> those who don't want to specify.
 
> > > +		/* Log connected channels */
> > > +		ina->attr_group[g++] = &ina3221_group[i];
> > > +		ina->channel_name[i] = str;
> > > +		ina->enable[i] = true;
> > 
> > I also don't see the need for defining the group dynamically. The
> > is_visible callback is very well suited for handling optional sysfs
> > attributes.

I tried is_visible but it looks like it won't be that neat to
implement as some attributes of this driver don't really pass
the channel index to the store()/show() but some other indexes.

If you are very against the dynamical group, I can drop it to
leave the sysfs node as it was.

And for the name nodes that I was talking about above, I will
add an sysfs store() function so non-DT users can set them,
and I also removed the confusing "unknown" default name.

I have been rewriting the DT binding and it should make a lot
of sense now comparing to this version. Will send v2 tomrrow.

Thanks
Nicolin