linux-kernel - Re: [PATCH v2] ALSA: xen-front: Refine indentations and constify snd_pcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Sep 2018 11:23:48 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Nick Simonov" <nicksimonovv@...il.com>
Cc:     <oleksandr_andrushchenko@...m.com>, <alsa-devel@...a-project.org>,
        <xen-devel@...ts.xenproject.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] ALSA: xen-front: Refine indentations and constify snd_pcm_ops

On Fri, 21 Sep 2018 11:21:35 +0200,
Nick Simonov wrote:
> 
> On Fri, Sep 21, 2018 at 08:51:51AM +0200, Takashi Iwai wrote:
> > On Fri, 21 Sep 2018 07:47:38 +0200,
> > Nick Simonov wrote:
> > > 
> > > snd_pcm_ops are not supposed to change. So mark the
> > > non-const structs as const. Also, refine indentation
> > > to increase readability.
> > > 
> > > Signed-off-by: Nick Simonov <nicksimonovv@...il.com>
> > > ---
> > > Changes v2:
> > > - Fix typo in commit description, ncrease to increase.
> > 
> > Since I already merged your first version, please resubmit as an
> > incremental patch.  At best, check the latest linux-next or my
> > sound.git tree for-next branch, and create a patch on its top.
> > 
> > 
> > thanks,
> > 
> > Takashi
> 
> Sorry I want to clarify, there is no mistakes in the code itself
> there is a typo in commit message. As I now there is no way to change
> commit message without rebase after merge, so which is the proper way in
> this case? leave it as is?

Then let's leave as is.


thanks,

Takashi