[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <42GsbF1vw9z9sCR@ozlabs.org>
Date: Fri, 21 Sep 2018 21:59:37 +1000 (AEST)
From: Michael Ellerman <patch-notifications@...erman.id.au>
To: Christophe Leroy <christophe.leroy@....fr>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>,
Paul Mackerras <paulus@...ba.org>,
Jianlin Shi <jishi@...hat.com>, Xin Long <lucien.xin@...il.com>
Cc: linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
stable@...r.kernel.org
Subject: Re: powerpc: fix csum_ipv6_magic() on little endian platforms
On Mon, 2018-09-10 at 06:09:04 UTC, Christophe Leroy wrote:
> On little endian platforms, csum_ipv6_magic() keeps len and proto in
> CPU byte order. This generates a bad results leading to ICMPv6 packets
> from other hosts being dropped by powerpc64le platforms.
>
> In order to fix this, len and proto should be converted to network
> byte order ie bigendian byte order. However checksumming 0x12345678
> and 0x56341278 provide the exact same result so it is enough to
> rotate the sum of len and proto by 1 byte.
>
> PPC32 only support bigendian so the fix is needed for PPC64 only
>
> Fixes: e9c4943a107b ("powerpc: Implement csum_ipv6_magic in assembly")
> Reported-by: Jianlin Shi <jishi@...hat.com>
> Reported-by: Xin Long <lucien.xin@...il.com>
> Cc: <stable@...r.kernel.org> # 4.18+
> Signed-off-by: Christophe Leroy <christophe.leroy@....fr>
> Tested-by: Xin Long <lucien.xin@...il.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/85682a7e3b9c664995ad477520f917
cheers
Powered by blists - more mailing lists