linux-kernel - Re: [PATCH v2] perf/x86/intel/uncore: Use boot_cpu_data.logical_proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d858f681-2d37-524e-4ff4-c340f5e2ded1@linux.intel.com>
Date:   Fri, 21 Sep 2018 08:33:02 -0400
From:   "Liang, Kan" <kan.liang@...ux.intel.com>
To:     Masayoshi Mizuma <msys.mizuma@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org
Cc:     Masayoshi Mizuma <m.mizuma@...fujitsu.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] perf/x86/intel/uncore: Use
 boot_cpu_data.logical_proc_id as the pkg id



On 9/20/2018 9:07 PM, Masayoshi Mizuma wrote:
> From: Masayoshi Mizuma <m.mizuma@...fujitsu.com>
> 
> Physical package id 0 is not always exists. We should use
> boot_cpu_data.logical_proc_id directly as the pkg id here.
> 
> Signed-off-by: Masayoshi Mizuma <m.mizuma@...fujitsu.com>

Reviewed-by: Kan Liang <kan.liang@...ux.intel.com>

Thanks,
Kan
> ---
>   arch/x86/events/intel/uncore_snbep.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c
> index 51d7c11..edaadac 100644
> --- a/arch/x86/events/intel/uncore_snbep.c
> +++ b/arch/x86/events/intel/uncore_snbep.c
> @@ -3061,7 +3061,7 @@ static struct event_constraint bdx_uncore_pcu_constraints[] = {
>   
>   void bdx_uncore_cpu_init(void)
>   {
> -	int pkg = topology_phys_to_logical_pkg(0);
> +	int pkg = boot_cpu_data.logical_proc_id;
>   
>   	if (bdx_uncore_cbox.num_boxes > boot_cpu_data.x86_max_cores)
>   		bdx_uncore_cbox.num_boxes = boot_cpu_data.x86_max_cores;
>