[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180921142941.5ymp7ksphgboxrwz@flea>
Date: Fri, 21 Sep 2018 16:29:41 +0200
From: Maxime Ripard <maxime.ripard@...tlin.com>
To: Rodrigo Exterckötter Tjäder
<rodrigo@...der.xyz>
Cc: Chen-Yu Tsai <wens@...e.org>, Rob Herring <robh+dt@...nel.org>,
Mark Rutland <mark.rutland@....com>,
linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: allwinner: Olimex A64-OLinuXino: fix
ethernet
On Wed, Sep 19, 2018 at 11:19:36AM -0300, Rodrigo Exterckötter Tjäder wrote:
> Without "allwinner,tx-delay-ps = <600>;" on the DTP it can receive packets
> but not send.
>
> Signed-off-by: Rodrigo Exterckötter Tjäder <rodrigo@...der.xyz>
Again, that commit log would be nice if it was a bit more
explicit. What is a DTP? How did you come up with that value? What is
the value used by Allwinner/Olimex, and why did you use another one if
you did?
Thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists